Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependencies and reinstall them when changing php version #130

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

fflorent
Copy link
Contributor

@fflorent fflorent commented Oct 15, 2023

Problem

  • When changing phpversion, we used to rely on ynh_remove_fpm_config helper to call ynh_remove_app_dependencies
  • However, the behavior changed with packaging v2, ynh_remove_fpm_config as I understand does not call this helper anymore.
  • Also the package did not reinstall the dependencies when changing the php version. For example, if we installed mysql, php{NEWVERSION}-mysql were not installed

Solution

  • explicitly call ynh_remove_app_dependencies
  • call ynh_install_app_dependencies with the dependencies

Resolves #131

PR Status

  • Code finished and ready to be reviewed/tested
  • The fix/enhancement were manually tested (if applicable)

Automatic tests

Automatic tests can be triggered on https://ci-apps-dev.yunohost.org/ after creating the PR, by commenting "!testme", "!gogogadgetoci" or "By the power of systemd, I invoke The Great App CI to test this Pull Request!". (N.B. : for this to work you need to be a member of the Yunohost-Apps organization)

@fflorent
Copy link
Contributor Author

!testme

@yunohost-bot
Copy link
Contributor

🎠
Test Badge

@ericgaspar ericgaspar changed the base branch from master to testing October 15, 2023 08:17
@fflorent fflorent marked this pull request as draft October 15, 2023 09:49
@fflorent fflorent changed the title explicitly call ynh_remove_app_dependencies when changing phpversion Remove dependencies and reinstall them when changing php version Oct 15, 2023
@fflorent fflorent marked this pull request as ready for review October 15, 2023 09:55
@fflorent
Copy link
Contributor Author

!testme

@yunohost-bot
Copy link
Contributor

Fingers crossed!
Test Badge

@alexAubin alexAubin merged commit 7d592fa into YunoHost-Apps:testing Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants